A surpisingly clean bill of health from valgrind on new navicache reader.

Have some warning cleanups at no extra cost.

git-svn-id: http://gpsbabel.googlecode.com/svn/trunk@4541 f51c46e8-681c-474f-0cfe-069cfd0219fb

diff --git a/gpsbabel/coastexp.cc b/gpsbabel/coastexp.cc
index e25c0e54ac77307ef52785f3466dc8e3908f73d8..7874b09b44d0024e23b7804122bbe715c413a203 100644 (file)
--- a/gpsbabel/coastexp.cc
+++ b/gpsbabel/coastexp.cc
@@ -698,9 +698,6 @@ ce_write(void)
      If doing waypoints, we write out the route waypoints (without the routes) and
      the standalone waypoints.
   */
-  time_t now = 0;
-  now = current_time().toTime_t();
-
   write_xml_header(ofd);
   write_xml_entity_begin1(ofd, "", "NavObjectCollection", "created",
                           ce_gen_current_time());

diff --git a/gpsbabel/exif.cc b/gpsbabel/exif.cc
index ff304143a426bee67dcf230f6c5735f7da5b77bb..d65e94a6e53a48c9ed50eabd4599921951e96bbf 100644 (file)
--- a/gpsbabel/exif.cc
+++ b/gpsbabel/exif.cc
@@ -589,7 +589,6 @@ exif_examine_app(exif_app_t* app)
   uint16_t endianess;
   uint32_t ident;
   gbfile* ftmp = exif_app->fcache;
-  int i;
 
   gbfrewind(ftmp);
   ident = gbfgetuint32(ftmp);
@@ -611,7 +610,7 @@ exif_examine_app(exif_app_t* app)
   gbfseek(ftmp, 6, SEEK_SET);
   app->fexif = gbfopen(NULL, "wb", MYNAME);
   app->fexif->big_endian = ftmp->big_endian;
-  i = gbfcopyfrom(app->fexif, ftmp, 0x7FFFFFFF);
+  gbfcopyfrom(app->fexif, ftmp, 0x7FFFFFFF);
 
   exif_read_app(exif_app);
 }

diff --git a/gpsbabel/navicache.cc b/gpsbabel/navicache.cc
index cc4a6ce8a40d9e9d5e3f3a0c5111eeb308abfd0e..1061a7de1a7566838031aa106c7a29dc6392b2fd 100644 (file)
--- a/gpsbabel/navicache.cc
+++ b/gpsbabel/navicache.cc
@@ -225,5 +225,5 @@ ff_vecs_t navicache_vecs = {
   nav_write,
   NULL,
   nav_args,
-  CET_CHARSET_ASCII, 0 /* CET-REVIEW */
+  CET_CHARSET_UTF8, 0  /* CET-REVIEW */
 };